Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Functional groupings parameters has max size of 24 #2470

Closed
conlain-k opened this issue Jul 30, 2018 · 0 comments
Closed

Functional groupings parameters has max size of 24 #2470

conlain-k opened this issue Jul 30, 2018 · 0 comments
Labels

Comments

@conlain-k
Copy link
Contributor

Bug Report

Core currently has a hardcoded max of 24 parameters per functional groupings in its policy table update code. Since there are more than 24 types of vehicle data, this presents the possibility of a perfectly fine policy table being marked invalid on the grounds. This is caused by the policy_table_interface_ext.xml files having a maxsize="24" in the Parameters typedef.

Reproduction Steps
  1. build SDL core in debug
  2. connect with policy server that has functional group with more than 24 parameters
  3. Force OnSystemRequest by connecting app
Expected Behavior

Core accepts policy table and uses it correctly

Observed Behavior

Core sees policy table as invalid and throws it out

OS & Version Information
Test Case, Sample Code, and / or Example App
DEBUG [30 Jul 2018 13:35:00,193][0x7f4052ffd700][Policy] /home/conlain/programs/sdl_core/src/components/policy/policy_regular/src/policy_manager_impl.cc:820 PolicyManagerImpl::IsPTValid: Errors: policy_table.policy_table.functional_groupings["DrivingCharacteristics-3"].rpcs["GetVehicleData"].parameters: array has invalid size
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants