Feature/issue 738 - Support for Short and Full UUID App ID #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #802 +/- ##
=============================================
+ Coverage 43.8% 43.83% +0.02%
- Complexity 3038 3057 +19
=============================================
Files 383 383
Lines 17795 17849 +54
Branches 1750 1753 +3
=============================================
+ Hits 7795 7824 +29
- Misses 9672 9698 +26
+ Partials 328 327 -1
Continue to review full report at Codecov.
|
bilal-alsharifi
changed the title
BrettyWhite
suggested changes
Jul 10, 2018
| public static final String GENERAL_APP_ID = "123e4567e8"; | ||
| public static final String GENERAL_FULL_APP_ID = "123e4567-e89b-12d3-a456-426655440000"; | ||
|
|
||
|
|
There was a problem hiding this comment.
please remove extra white space
BrettyWhite
approved these changes
Jul 10, 2018
added 2 commits
August 23, 2018 11:11
# Conflicts: # sdl_android/src/androidTest/java/com/smartdevicelink/test/Test.java
joeygrover
reviewed
Aug 27, 2018
|
|
||
| /** | ||
| * Sets a unique ID, which an app will be given when approved | ||
| * |
There was a problem hiding this comment.
Please add a note that this will automatically parse the full id into the smaller app id and set it
joeygrover
reviewed
Aug 27, 2018
|
|
||
| @Override | ||
| public void format(Version rpcVersion, boolean formatParams) { | ||
| if (getFullAppID() == null){ |
There was a problem hiding this comment.
Please add a check here if(rpcVersion == null || rpcVersion.getMarjor() >= 5)
added 2 commits
August 27, 2018 13:26
joeygrover
approved these changes
Aug 27, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #738
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
fullAppIDfield inRegisterAppInterface.Summary
This PR adds a new
fullAppIDparameter toRegisterAppInterfaceRPC as described in the proposal.CLA