Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Namespace capitalization #33

Closed
7 tasks done
lea255ace opened this issue Feb 10, 2015 · 2 comments
Closed
7 tasks done

Namespace capitalization #33

lea255ace opened this issue Feb 10, 2015 · 2 comments
Labels
best practice

Comments

@lea255ace
Copy link
Contributor

lea255ace commented Feb 10, 2015 •
edited by jacobkeeler
Loading

The following namespaces contain capital letters:

  • Errors
  • Formatters
  • NsJSONHandler
  • NsMessageBroker
  • NsSmartDeviceLink
  • NsSmartObjects
  • protocol_handlerHandler

This is inconsistent with the style guide, and should be fixed. This will not be addressed in #25, and needs its own fix branch.
dev-gh pushed a commit to dev-gh/sdl_core that referenced this issue Jun 7, 2016
@anosach-luxoft
Merge pull request smartdevicelink#33 from dev-gh/fix/backmerge_posix…
a989920 
…_build

Fixes unit tests linkage issue
Related-issues: APPLINK-22713, APPLINK-22716
LuxoftAKutsan pushed a commit that referenced this issue Feb 23, 2017
Merge pull request #33 from CustomSDL/feature/REVSDL-1134-remove-OnPr…
9a489af 
…imaryDevice

REVSDL-1134: removed handling of deprecated of OnPrimaryDevice
@jacobkeeler
Copy link
Contributor

Several of the namespaces mentioned were present in the 3rd party libraries, which don't need to be edited, so I removed those entries. Will submit a PR for the rest

@jacobkeeler jacobkeeler mentioned this issue Aug 29, 2018
Merged
1 task
@jacobkeeler
Copy link
Contributor

Closing with the merge of #2552

@jacobkeeler jacobkeeler mentioned this issue Sep 5, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
best practice
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobkeeler @lea255ace