Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Initialization (et al) method return values #34

Closed
lea255ace opened this issue Feb 10, 2015 · 0 comments
Closed

Initialization (et al) method return values #34

lea255ace opened this issue Feb 10, 2015 · 0 comments

Comments

@lea255ace
Copy link
Contributor

Many methods have an int or bool return type, but never vary the return value and are not checked in the calling code.

transport_manager_impl.cc:

int TransportManagerImpl::Init() {                                               
  LOG4CXX_TRACE(logger_, "enter");                                               
  all_thread_active_ = true;                                                     
  is_initialized_ = true;                                                        
  LOG4CXX_TRACE(logger_, "exit with E_SUCCESS");                                 
  return E_SUCCESS;                                                              
}

Call from life_cycle.cc:

transport_manager_->Init();

Either return values should be checked or functions should have return type of void.

LuxoftAKutsan pushed a commit that referenced this issue Feb 23, 2017
…other-sections

REVSDL-1194: Fix support moduleTypes for other sections
davidswi pushed a commit to davidswi/sdl_core that referenced this issue Oct 25, 2017
…/SDL-1053 to develop

* commit 'a06db5a879dda9537a631a1caa64f814ab5442c5':
  SDL-1053 Add termination process for device scanner
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants