Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Modernize Ubuntu Support #2180

Merged
merged 4 commits into from
May 14, 2018
Merged

Modernize Ubuntu Support #2180

merged 4 commits into from
May 14, 2018

Conversation

jacobkeeler
Copy link
Contributor

@jacobkeeler jacobkeeler commented May 9, 2018

Fixes #2170 (partially)

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Build and run unit tests on Ubuntu 18.04, fixing any build and test failures

Summary

Adds support for Ubuntu 18.04

Changelog

Enhancements
  • Modify project to successfully build on the new Ubuntu 18.04
    • Add checks for systems that no longer support SSL3
    • Fix test failures on Ubuntu 16.04 and 18.04
    • Replace deprecated readdir_r with readdir

Tasks Remaining:

  • Fix new warnings generated on Ubuntu 18.04

CLA

jacobkeeler and others added 4 commits October 28, 2016 15:57
`readdir_r` is deprecated as of glibc 2.24 in favor of `readdir`.  In
the use cases of `readdir_r`, it can safely be replaced with `readdir`.

POSIX specifies that "The pointer returned by readdir() points to data
which may be overwritten by another call to readdir() on the same
directory stream. This data is not overwritten by another call to
readdir() on a different directory stream".

Since the code does not reuse the directory stream in a way that could
cause threading issues, we can safely use `readdir`.  This prevents
possible issues with buffer overflows in `readdir_r` and simplifies the
code.
Many linux distros such as Debian and Arch Linux are now shipping
OpenSSL libraries without SSL3 support. This commit allows the project
to be still be built with security in these instances.
@jacobkeeler
Copy link
Contributor Author

Note, a dependency change from libssl-dev to libssl1.0-dev is necessary to build this for Ubuntu 18.04

@jacobkeeler jacobkeeler merged commit 5b3764d into develop May 14, 2018
@jacobkeeler jacobkeeler deleted the feature/modern_ubuntu_support branch May 14, 2018 14:08
@jacobkeeler jacobkeeler mentioned this pull request Jun 11, 2018
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants