Fix V5 protocol message bson params #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrapitis
approved these changes
Jun 7, 2018
|
@theresalech this PR is ready for review. |
AKalinich-Luxoft
force-pushed
the
fix/fix_v5_protocol_messages_bson_params
branch
from
161278f to
038b311
Compare
|
@AKalinich-Luxoft There are a lot of merge conflicts now that getSystemTime has been merged. Can you rebase this PR on the current develop? |
|
Also PR has 38 unit test failures in security_manager_test |
Currently, SDL Core ignores both the CertificatePath and KeyPath keywords that would allow the system integrator to specify certificates for their environment, instead SDL Core only processes the certificate provided via the policy table. This fix makes these keywords functional. Following changes were done: - Added getters for CertificatePath and KeyPath parameters in SecurityManagerSettings class to provide another components an access to these properties - Added methods for loading certificate and private key data from the files specified by CertificatePath and KeyPath keywords - CryptoManager component implementation was updated. Now this component also read certificate data from files (if they are present and accessible) on its own initialization
SDL Core should update the module certificate in the local file system when a policy table update occurs. Currently SDL core is retrieving its certificate directly out of the policy table. This fix provides functionality for saving module certificate to the file system. Following changes were done: - Added getters for CertificatePath and KeyPath parameters in SecurityManagerSettings class to provide another components an access to these properties - Added methods for saving certificate and private key data to the files specified by CertificatePath and KeyPath keywords - CryptoManager component implementation was updated. Now this component also saves certificate data to files (if write permission allowed) after PTU
Added new expectations for a security tests due to some changes in the security flow
Conflicts: src/components/security_manager/src/crypto_manager_impl.cc
Also was removed redundant logic
…Types Updated encrypt/decrypt frame conditions Fixed bson object double allocation
AKalinich-Luxoft
force-pushed
the
fix/fix_v5_protocol_messages_bson_params
branch
from
038b311 to
919f8ed
Compare
Jack-Byrne
approved these changes
Jun 18, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2142
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Covered by unit tests
ATF scripts
Summary
There was a problem with V5 control frames encryption/decryption related to the wrong conditions in encrypt/decrypt functions in protocol manager. Also there was a problem with allocated bson params object passed as a pointer to another place.
NOTE
This fix should be merged after #2105 and #2068 features as it contains commit history from these branches. Please review only the last commit from this PR.
CLA