Feature/boost system command implementation #2237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuxoftAKutsan
approved these changes
Oct 17, 2018
|
Not sure when this changed but SDL Core no longer uses the system.cc utility. system.h and system.cc are not included anywhere in the source code. �Closing. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1523.
This PR is ready for review.
Risk
This PR makes no API changes.
Requires Boost support on host system.
Testing Plan
Run gtest test suite and ATF tests to ensure no regressions/modified functionality. There are existing tests for this code, this is just an implementation change.
Summary
Change fork/spawnvp implementation over to a
boost::process::childcallChangelog
Breaking Changes
Enhancements
Bug Fixes
Tasks Remaining:
CLA