-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature/boost datetime implementation #2278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also cleans up date_time namespacing but maintains helper functions
LuxoftAKutsan
approved these changes
Jun 25, 2018
Can one of the admins verify this patch? |
…into feature/boost_datetime_implementation
jacobkeeler
approved these changes
Aug 22, 2018
dec6e04
to
370c752
Compare
jacobkeeler
approved these changes
Aug 28, 2018
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1523.
This PR is ready for review.
Risk
This PR makes major API changes.
Testing Plan
Use ATF and unit tests to ensure that code using datetime utilities still works correctly
Summary
Remove uses of
struct timeval
and replace it withboost::posix_time::time_duration
, allowing platform-independent usage and cleaner use/helper functions. Boost handles most helper functions, with topical wrappers to preserve old functionality and abstract from the underlying implementation.Also removes useless
date_time::DateTime
class that just held static members in favor of a flatdate_time
namespace containing all helper functions.Note that
src/components/telemetry_monitor/src/telemetry_monitor.cc
still uses struct timeval as required for theselect
POSIX call; this should eventually be replaced as well.Tasks Remaining:
struct timeval
allowed some poorly-defined behavior such as overflowing thetv_usec
field (over 1 million microseconds). Boost's implementation doesn't allow mutating specific fields, meaning that changing said behavior could cause a bug.CLA