Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SDL shall not put RC applications to HMI level NONE when user disables RC in HMI #2373

Merged
merged 3 commits into from
Aug 27, 2018

Conversation

LitvinenkoIra
Copy link
Contributor

@LitvinenkoIra LitvinenkoIra commented Jul 17, 2018

Fixes #2377
https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0181-keep-rc-app-hmi-level-when-disable-rc.md

This PR is [ready] for review.

Risk

This PR makes [no] API changes.

Testing Plan

test set: https://github.com/smartdevicelink/sdl_atf_test_scripts/blob/fix/rc_disabling/test_sets/rc_CLIMATE_RADIO.txt
PR for scripts: smartdevicelink/sdl_atf_test_scripts#1979

Summary

Fix behavior in case when RC functionality is disabled from HMI

For manual testing use:
HMI from : https://github.com/smartdevicelink/sdl_hmi/tree/develop

CLA

@vkushnirenko-luxoft
Copy link
Contributor

Rebuild required

Copy link

@yang1070 yang1070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me

@yang1070
Copy link

@theresalech Ford has reviewed, tested and approve this PR. It is ready for review by Livio.

@theresalech
Copy link
Contributor

@yang1070 thanks! This feature is not currently planned for the Core 5.0 release, so we will plan to review for the following release, unless time allows review for 5.0.

@LuxoftAKutsan
Copy link
Contributor

@JackLivio @jacobkeeler this PR rebased on the latest develop

@jacobkeeler
Copy link
Contributor

jacobkeeler commented Aug 23, 2018

@LuxoftAKutsan Seems to work correctly, but I experienced an issue with the SDL HMI with the following scenario

  1. Bring app to FULL
  2. Go to menu and disable RC - No OnHMIStatus (as expected)
  3. Go back to the app menu - No OnHMIStatus
  4. Activate app again (select No when prompted whether to activate RC) - No OnHMIStatus
  5. Go back to the app menu - OnHMIStatus(LIMITED) (as expected)
  6. Activate app again (select No again when prompted whether to activate RC) OnHMIStatus(FULL) (as expected)

All changes to HMI Status are normal past this step, but until the second time that you activate the app after disabling RC, the HMI Status does not appear to update.

@GetmanetsIrina
Copy link

@jacobkeeler , the scenario must be the next:

  1. Bring app to FULL
  2. Go to menu and disable RC - OnHMIStatus(LIMITED) (by step 'Go to menu')
  3. Go back to the app menu - No OnHMIStatus
  4. Activate app again (select No when prompted whether to activate RC) - OnHMIStatus(FULL)
  5. Go back to the app menu - OnHMIStatus(LIMITED) (as expected)
  6. Activate app again (select No again when prompted whether to activate RC) OnHMIStatus(FULL) (as expected)

@LitvinenkoIra
Copy link
Contributor Author

LitvinenkoIra commented Aug 27, 2018

@jacobkeeler I tested the scenario that you described
and also I agree with comment from @GetmanetsIrina

So for now we have the following issue on HMI side:

  1. Bring app to FULL
  2. Go to menu and disable RC -
    expected: OnHMIStatus(LIMITED) (by step 'Go to menu')
    observed: No OnHMIStatus

I will create a separate issue for this, because this is not RC related defect.

@LitvinenkoIra
Copy link
Contributor Author

HMI issue: smartdevicelink/sdl_hmi#101

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants