-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
SDL shall not put RC applications to HMI level NONE when user disables RC in HMI #2373
Conversation
Rebuild required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me
@theresalech Ford has reviewed, tested and approve this PR. It is ready for review by Livio. |
@yang1070 thanks! This feature is not currently planned for the Core 5.0 release, so we will plan to review for the following release, unless time allows review for 5.0. |
bd98c67
to
5cb2bf2
Compare
5cb2bf2
to
07316fe
Compare
@JackLivio @jacobkeeler this PR rebased on the latest develop |
@LuxoftAKutsan Seems to work correctly, but I experienced an issue with the SDL HMI with the following scenario
All changes to HMI Status are normal past this step, but until the second time that you activate the app after disabling RC, the HMI Status does not appear to update. |
@jacobkeeler , the scenario must be the next:
|
@jacobkeeler I tested the scenario that you described So for now we have the following issue on HMI side:
I will create a separate issue for this, because this is not RC related defect. |
HMI issue: smartdevicelink/sdl_hmi#101 |
Fixes #2377
https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0181-keep-rc-app-hmi-level-when-disable-rc.md
This PR is [ready] for review.
Risk
This PR makes [no] API changes.
Testing Plan
test set: https://github.com/smartdevicelink/sdl_atf_test_scripts/blob/fix/rc_disabling/test_sets/rc_CLIMATE_RADIO.txt
PR for scripts: smartdevicelink/sdl_atf_test_scripts#1979
Summary
Fix behavior in case when RC functionality is disabled from HMI
For manual testing use:
HMI from : https://github.com/smartdevicelink/sdl_hmi/tree/develop
CLA