Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1493. Is a duplicate of #2257, but rebased off the latest develop. The old version was too bogged down by merge conflicts, so this is a salvage of that.
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Run unit tests and ATF tests. Will most likely require extensive testing due to number of files altered.
Summary
Converts instances of
Utils::SharedPtr
tostd::shared_ptr
, supported in C++11. Also usesstd::make_shared
. Converts non-standard functionality to use STL equivalents, cleans up lots of shared_ptr allocation issues.Should only modify shared pointers in-place with no change in functionality. Internal API should be basically identical.
Changelog
Massive replacement of sharedPtrs
Conversion to use correct allocation processes in shared_ptr initialization
fix namespacing and remove custom implementations of non-standard functionality
NOTE:
Also modifies
application_manager_impl.h
to usesubscribed_way_points_apps_list_.find(app->app_id())
instead ofsubscribed_way_points_apps_list_.find(app)
.The
subscribed_way_points_apps_list_
is astd::set<int32_t>
, so indexing into it with a shared_ptr makes no sense. This is either poorly defined behavior or a bug. It may be the case that this is outside the scope of this PR, but the modification is required for the code to compile and the current code still passes all unit and SDL smoke tests.Enhancements
Bug Fixes
Tasks Remaining:
CLA