Feature/Audio Source AM/FM/XM/DAB #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LitvinenkoIra
force-pushed
the
feature/audio_source_am_fm_xm
branch
from
121d048 to
1ce6553
Compare
LuxoftAKutsan
approved these changes
Jul 26, 2018
|
why this change mixed with other existing changes? |
yang1070
approved these changes
Jul 31, 2018
|
@theresalech Ford has reviewed, tested and approves the change. It is ready for Livio to review. |
|
Can one of the admins verify this patch? |
LuxoftAKutsan
force-pushed
the
feature/audio_source_am_fm_xm
branch
from
1ce6553 to
0b63a0f
Compare
LuxoftAKutsan
force-pushed
the
feature/audio_source_am_fm_xm
branch
from
0b63a0f to
ceea340
Compare
|
@theresalech @jacobkeeler Ford approves this change. It need to be merged after #2207 |
jacobkeeler
approved these changes
Aug 17, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2338
Note: Implementation is based on #1798, so this PR should be merged after #2207
This PR is [ready] for review.
Risk
This PR makes [major] API changes.
Testing Plan
PR with ATF scripts: smartdevicelink/sdl_atf_test_scripts#1985
Summary
implementation of https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0182-audio-source-am-fm-xm.md
CLA