Allow empty moduleType array in PT #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2547
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Start Core
Connect app
Perform RC RPC, expect success
Cycle Core and reconnect app
Perform RC RPC, expect success
Summary
Updates the SQL related code to allow for empty moduleType in the SQL database. If there is a module type array present in the PT but it is empty, then it will allow all module types. These changes fix an issue where empty moduleType array would work on the initial cycle on core, but would not work on future ignition cycles.
CLA