Add additional check for non-manadatory parameters #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OnPutFile notification has non mandatory parameters `fileSize` and `length`. If the mobile application has no provided appropriate parameters SDL sends `fileSize`: null as json value to HMI. The commit fixes the issue and simply remove non mandatory parameter in case mobile app sends nothing for one.
ZhdanovP
requested review from
jacobkeeler,
AByzhynar,
IGapchuk,
AKalinich-Luxoft,
Itileda,
LuxoftAKutsan,
LitvinenkoIra,
mked-luxoft and
Ypostolov
IGapchuk
approved these changes
Sep 5, 2018
AKalinich-Luxoft
approved these changes
Sep 5, 2018
LuxoftAKutsan
approved these changes
Sep 5, 2018
Ypostolov
approved these changes
Sep 5, 2018
jacobkeeler
approved these changes
Sep 5, 2018
jacobkeeler
deleted the
fix/sdl_does_not_check_for_non_mandatory_parameters
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2443
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
ATF script - smartdevicelink/sdl_atf_test_scripts#2020
Summary
The OnPutFile notification has non mandatory parameters
fileSizeandlength. If the mobile application has no providedappropriate parameters SDL sends
fileSize: null as json value to HMI.The commit fixes the issue and simply remove non mandatory parameter in
case mobile app sends nothing for one.
Tasks Remaining:
CLA