Fix/Set mandatory=false for optional response params #3052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
ATF tests
Summary
This PR changes the
mandatory
attribute for parameters(other thansuccess
andresultCode
) in RPC responses(in the MOBILE_API) frommandatory=true
tomandatory=false
.Currently, core is only guaranteed to return
resultCode
andsuccess
for all RPC responses to mobile. In the case of an error, core may not return other parameters. If those other parameters havemandatory=true
in the API spec that could cause issues on the mobile side.CLA