Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Accepted] SDL 0097 - Tire pressure additions #288

Closed
theresalech opened this issue Sep 13, 2017 · 7 comments
Closed

[Accepted] SDL 0097 - Tire pressure additions #288

theresalech opened this issue Sep 13, 2017 · 7 comments

Comments

@theresalech
Copy link
Contributor

Hello SDL community,

The review of "Tire pressure additions" begins now and runs through September 19, 2017. The proposal is available here:

https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0097-tire-pressure-additions.md

Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:

#288

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:

  • Is the problem being addressed significant enough to warrant a change to SDL?
  • Does this proposal fit well with the feel and direction of SDL?
  • If you have used competitors with a similar feature, how do you feel that this proposal compares to those?
  • How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
    Please state explicitly whether you believe that the proposal should be accepted into SDL.

More information about the SDL evolution process is available at

https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md

Thank you,
Theresa Lech

Program Manager - Livio
theresa@livio.io

@Jack-Byrne
Copy link
Contributor

Jack-Byrne commented Sep 19, 2017

@kshala-ford You have tire pressure to only be returned in kilo pascals. I am not sure if all OEM's use that unit of measurement, or if some might prefer to have the option to use PSI instead.

Returning the associated unit of measurement with the measurement value might also be helpful for developers depending on the country they are from, especially if they are more familiar with imperial units over the metric system.

I am suggesting to add a pressure struct that includes the unit (Pa/PSI) and value (float).

@joeljfischer
Copy link
Contributor

@JackLivio I think it's better for us to leave this complexity out of the spec and allow devs to do the conversions themselves. It's so easy for them to do that I don't think we need to handle that complexity.

@Toyota-Sbetts
Copy link
Contributor

Toyota-Sbetts commented Sep 19, 2017

@joeljfischer This assumes all OEM systems return kilopascal, otherwise the HU will be converting the value so the app can convert it back. While not necessarily difficult, it does seem redundant.

Edit: There are also other common units of measurement for pressure such as Bar and Atmosphere. If we support these as well, it will become more complex for the app side and/or HU side to do the conversion.

@joeljfischer
Copy link
Contributor

@Toyota-Sbetts That kind of expansion is what I'm trying to avoid. I'd rather provide a single data point in a constant unit and allow developers to do those conversions as necessary, even if it means the HU needs to convert on its end. This may lead to a slight loss of precision, but I don't think that should be a large issue.

@Jack-Byrne
Copy link
Contributor

@joeljfischer @Toyota-Sbetts After looking at other vehicle data types in the mobile api, they all use the SI measurement system (odometer - km, externalTemperature - celsius, speed - km/h). Also Pascals is the SI unit of pressure.

I take back my original suggestion and agree with the original proposal.

If we wanted to talk about converting between different units of pressure, then we probably need to do the same for the other vehicle data units.

@theresalech
Copy link
Contributor Author

After the discussion that took place on this issue, the Steering Committee voted to accept this proposal as is.

@theresalech theresalech changed the title [In Review] SDL 0097 - Tire pressure additions [Accepted] SDL 0097 - Tire pressure additions Sep 20, 2017
@smartdevicelink smartdevicelink locked and limited conversation to collaborators Sep 20, 2017
@theresalech
Copy link
Contributor Author

Issues Entered:
Core
iOS
Android
RPC

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

4 participants