Revise SDL-0150 - Video Streaming State #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theresalech This is ready for review |
This was referenced Jul 25, 2018
This was referenced Jul 26, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise SDL-0150 - Video Streaming State
Introduction
Alter
videoStreamingStateto be optional instead of mandatory.Motivation
The existing proposal is a major RPC version change and causes high impact backward compatibility issues that are very difficult to mitigate.
Proposed solution
Change the
videoStreamingStateparameter to optional.Potential downsides
None the author could identify.
Impact on existing code
Makes a major version change into a minor version change.
Alternatives considered
No alternatives were considered.