Revise SDL-0153 Support for Short and Full UUID App ID #578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This is a revision to make fullAppID mandatory="false" and to add a clarifying note regarding appID case insensitivity.
Motivation
Make Full App ID Non Mandatory
There is language in the original proposal conflicting with the fullAppID RPC spec definition.
From proposal:
In order for this case to be possible, fullAppID must be non mandatory. In addition, even with mobile version negotiation, making fullAppID mandatory would cause a breaking change in RegisterAppInterfaceRequest for legacy applications.
Include Note Regarding AppID Case Insensitivity
During the Core implementation of this original proposal, it was discovered that there was an existing behavior in Core that converts incoming appIDs from a RegisterAppInterfaceRequest to lowercase. I am adding this note to the proposal for documentation and visibility purposes.
Proposed solution
Change fullAppID rpc spec signature to:
fullAppID
Potential downsides
None the author could identify.
Impact on existing code
Change mandatory value
fullAppID
in mobile_api.xml in RPC Spec to false.Alternatives considered
No alternatives were considered.