Revise SDL-0119 SDL Passenger Mode #775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Update SDL-0119 SDL Passenger mode for usability improvements: first, to swipe down instead of up to match most default animations; second, to only show the lock screen again if the dismissal enabled parameter is set to
false
after it had been set totrue
.Motivation
The design and usability of this feature on the mobile side is lacking in the current proposal and can be improved.
Proposed solution
The changes are two part:
Change the swipe up gesture to be swipe down. Because iOS and many android phones have a default modal animation of transitioning from the bottom and back to the bottom, a swipe down will follow the movement of the lock screen. This will make more sense to the user than swiping up and the lock screen moving down.
Change the re-appearance of the lock screen to only re-appear if both the lock screen becomes required again and the
lockScreenDismissalEnabled
parameter changes tofalse
. If thelockScreenDismissalEnabled
parameter istrue
, and the lock screen has been dismissed, it should remain dismissed. Otherwise, this would lead to a very frustrating user experience for a passenger who is in stop and go traffic as the lock screen will constantly re-appear.Potential downsides
Android's default animation can vary by phone and may not always be a "from the bottom" modal animation. Therefore the swipe may not always match the animation.
If the lock screen was dismissed, it cannot be re-enabled unless the head unit sets the
lockScreenDismissalEnabled
to false.Impact on existing code
The mobile libraries will need to be updated
Alternatives considered
lockScreenDismissalEnabled
is set tofalse
, it could only persist until the device is locked.