SDL 0231 Menu Tiles Revision #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theresalech Ready for review. |
theresalech
approved these changes
Jul 29, 2019
theresalech
added
core
hmi
ios
java suite
review ready
review revision update
rpc
labels
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This is a revision to remove the default value (
defvalue="LIST") from the menuLayout parameter introduced by the original proposal.Motivation
While testing for regressions SetGlobalProperties the author noticed that including a defvalue in the RPC means that any time that the menuLayout parameter is omitted, the menuLayout would be set to LIST. This is problematic if an app had previously set TILES as the menu layout in a previous SetGlobalProperties Request.
Proposed Solution
In all mentions of menuLayout, the default value should be removed. This applies to SetGlobalProperties and AddSubMenu requests in the mobile and hmi apis.
Potential downsides
No downsides identified with the API change.
Impact on existing code
Core and mobile will need to update their RPC spec implementations to not include or autofill a default parameter for menuLayout.
Alternatives considered
Leave the default value as is. The author does not believe this is an ideal solution.