Implementation of Expandable design for proprietary data exchange feature #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AKalinich-Luxoft
suggested changes
Apr 19, 2018
app/view/sdl/SystemRequestView.js
Outdated
| { | ||
| elementId: 'systemRequestLabel', | ||
| classNames: 'systemRequestLabel', | ||
| content: 'System Request' |
There was a problem hiding this comment.
@Ypostolov please rename content to Request Subtypes
added 2 commits
April 19, 2018 14:34
change name systemRequest Label Bugfix error at the ffw/BasicCommunication OnSystemRequest method with subType parameter which was null and which was calling. Change name systemRequest Label from 'System request' to 'requestSubType'.
…oprietary_data_exchange Bugfix error at the OnSystemRequest method and
AKalinich-Luxoft
approved these changes
Apr 20, 2018
AKalinich-Luxoft
changed the title
AKalinich-Luxoft
changed the title
AKalinich-Luxoft
merged commit 84864dd
into
smartdevicelink:feature/expandable_design_for_proprietary_data_exchange
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes smartdevicelink/sdl_core#1734
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
HMI behavior should be tested manually
Summary
Made the following changes:
CLA