Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/low voltage #109

Merged
merged 10 commits into from
Aug 21, 2018
Merged

Feature/low voltage #109

merged 10 commits into from
Aug 21, 2018

Conversation

KhrystynaDubovyk
Copy link
Contributor

@KhrystynaDubovyk KhrystynaDubovyk commented Jun 26, 2018

Technical task : #2233
This PR is ready for review.
This pull request contains the implementation of the proposal : 0170-sdl-behavior-in-case-of-Low-Voltage

Risk

This PR makes [no] API changes.

Testing Plan

Unit tests are provided
ATF tests are provided

Summary

Implemented handling of LOW VOLTAGE, WAKE_UP, IGNITION_OFF
signals based on real-time UNIX signals

CLA

@sdl-robot
Copy link

@sdl-robot
Copy link

@sdl-robot
Copy link

* SDL and the PoliciesManager must persist 'consumer data' (resumption-related + local PT) periodically and independently of the external events.

#### SDL resumes its regular work after receiving a "WAKE_UP" signal:
* After receiving a `WAKE_UP` signal, all applications will be unregistered and the device disconnected.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhrystynaDubovyk This point is missed in diagram

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AByzhynar, thank you
fixed with 7047ffd, 0264c5e

@sdl-robot
Copy link

@sdl-robot
Copy link

@LuxoftAKutsan LuxoftAKutsan requested a review from yang1070 July 27, 2018 14:12
[MAIN]
LowVoltageSignal = 1 ; Offset for from SIGRTMIN
WakeUpSignal = 2 ; Offset for from SIGRTMIN
IgnitionOffSignal = 2 ; Offset for from SIGRTMIN

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, shall be
IgnitionOffSignal = 3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yang1070, thank you.
fixed f596913

* SDL stops audio/video streaming services.
* All transports are unavailable for SDL.
* SDL persists resumption related data stored before receiving a `LOW_VOLTAGE` signal.
* SDL and the PoliciesManager must persist 'consumer data' (resumption-related + local PT) periodically and independently of the external events.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the word periodically is confusing to me, does that mean PoliciesManager can still do some writing to the disk periodically after receives a low voltage signal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yang1070, thank you.
fixed f596913

@sdl-robot
Copy link

Copy link

@yang1070 yang1070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sdl-robot
Copy link

@yang1070
Copy link

@theresalech Ford has reviewed and approved this PR. It is ready for Livio to review.

@theresalech theresalech requested a review from jacobkeeler July 30, 2018 19:10
@sdl-robot
Copy link

@jacobkeeler jacobkeeler merged commit 0c6f61e into develop Aug 21, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants