-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature/low voltage #109
Feature/low voltage #109
Conversation
Add LowVoltage index Add low_voltage diagram
Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/ba0dbe4f00e640aaf59250a4829f2d9d87980117/overview/ |
Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/b10a0f0622919954ddd2bb6b9d418ac7f7abdfb1/overview/ |
Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/1ec70d811810068d9be8ef81e84d96ed35f3ce16/overview/ |
docs/UnixSignals/LowVoltage/index.md
Outdated
* SDL and the PoliciesManager must persist 'consumer data' (resumption-related + local PT) periodically and independently of the external events. | ||
|
||
#### SDL resumes its regular work after receiving a "WAKE_UP" signal: | ||
* After receiving a `WAKE_UP` signal, all applications will be unregistered and the device disconnected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KhrystynaDubovyk This point is missed in diagram
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AByzhynar, thank you
fixed with 7047ffd, 0264c5e
Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/7047ffd3a19230ba5c5af90345d89c7d1e0080d9/overview/ |
Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/0264c5ebfc2e9ef429e6511afb0a12773ee62840/overview/ |
docs/UnixSignals/LowVoltage/index.md
Outdated
[MAIN] | ||
LowVoltageSignal = 1 ; Offset for from SIGRTMIN | ||
WakeUpSignal = 2 ; Offset for from SIGRTMIN | ||
IgnitionOffSignal = 2 ; Offset for from SIGRTMIN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo, shall be
IgnitionOffSignal = 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/UnixSignals/LowVoltage/index.md
Outdated
* SDL stops audio/video streaming services. | ||
* All transports are unavailable for SDL. | ||
* SDL persists resumption related data stored before receiving a `LOW_VOLTAGE` signal. | ||
* SDL and the PoliciesManager must persist 'consumer data' (resumption-related + local PT) periodically and independently of the external events. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the word periodically
is confusing to me, does that mean PoliciesManager can still do some writing to the disk periodically after receives a low voltage signal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/f596913186b6eb2dbbac6d774a8f851363133979/overview/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/c76915c668652b2d0de465fbf0bcdb5f6c9a89a4/overview/ |
@theresalech Ford has reviewed and approved this PR. It is ready for Livio to review. |
Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/672ab8b838ac1d9695afa21120174f0a5fb817b2/overview/ |
Technical task : #2233
This PR is ready for review.
This pull request contains the implementation of the proposal : 0170-sdl-behavior-in-case-of-Low-Voltage
Risk
This PR makes [no] API changes.
Testing Plan
Unit tests are provided
ATF tests are provided
Summary
Implemented handling of LOW VOLTAGE, WAKE_UP, IGNITION_OFF
signals based on real-time UNIX signals
CLA