Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SDLVideoStreamingRange init not working properly #2050

Closed
FrankElias77 opened this issue Oct 20, 2021 · 1 comment
Closed

SDLVideoStreamingRange init not working properly #2050

FrankElias77 opened this issue Oct 20, 2021 · 1 comment
Labels
bug A defect in the library manager-streaming-video Relating to the manager layer - video streaming

Comments

@FrankElias77
Copy link
Contributor

FrankElias77 commented Oct 20, 2021

Bug Report

The video stream fails when constructing our SDLVideoStreamingRange object using the init(), then setting a minimumDiagonal or minimumAspectRatio/maximumAspectRatio without setting the dimensions.
SDLVideoStreamingRange works properly with other init methods.

Reproduction Steps
  1. Set our SDLVideoStreamingRange
    let landscapeDiagonal = SDLVideoStreamingRange()
    landscapeDiagonal.minimumDiagonal = 5.0
  2. streamingMediaConfig.supportedLandscapeStreamingRange = landscapeDiagonal
    streamingMediaConfig.supportedPortraitStreamingRange = SDLVideoStreamingRange.disabled()
  3. Launch app
Expected Behavior

App streams successfully

Observed Behavior

App does not stream

OS & Version Information
  • iOS Version: 15.0/13.0
  • SDL iOS Version: 7.3.0-rc.1
  • Testing Against: SDL Core/Sync 3
Test Case, Sample Code, and / or Example App

https://smartdevicelink.com/en/guides/iOS/video-streaming-for-navigation-apps/video-streaming-ios/#creating-the-video-streaming-ranges

@FrankElias77 FrankElias77 added bug A defect in the library manager-streaming-video Relating to the manager layer - video streaming labels Oct 20, 2021
@joeljfischer
Copy link
Contributor

Doing let landscapeDiagonal = SDLVideoStreamingRange() is the same as doing let landscapeDiagonal = SDLVideoStreamingRange.disabled(). Creating an empty video streaming range, therefore, sets the resolutions to disabled. This should either (1) be made clear in .h documentation. (2) Changed to set the minimum and maximum resolution to nil (major version change). (3) Disable init (this would be a major version change, so we'd have to deprecate it).

If init survives, we should also set the min/max aspect ratio and the min diagonal. I think I prefer 3.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug A defect in the library manager-streaming-video Relating to the manager layer - video streaming
Projects
None yet
Development

No branches or pull requests

2 participants