You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The video stream fails when constructing our SDLVideoStreamingRange object using the init(), then setting a minimumDiagonal or minimumAspectRatio/maximumAspectRatio without setting the dimensions.
SDLVideoStreamingRange works properly with other init methods.
Reproduction Steps
Set our SDLVideoStreamingRange
let landscapeDiagonal = SDLVideoStreamingRange()
landscapeDiagonal.minimumDiagonal = 5.0
Doing let landscapeDiagonal = SDLVideoStreamingRange() is the same as doing let landscapeDiagonal = SDLVideoStreamingRange.disabled(). Creating an empty video streaming range, therefore, sets the resolutions to disabled. This should either (1) be made clear in .h documentation. (2) Changed to set the minimum and maximum resolution to nil (major version change). (3) Disable init (this would be a major version change, so we'd have to deprecate it).
If init survives, we should also set the min/max aspect ratio and the min diagonal. I think I prefer 3.
Bug Report
The video stream fails when constructing our
SDLVideoStreamingRange
object using theinit()
, then setting a minimumDiagonal or minimumAspectRatio/maximumAspectRatio without setting the dimensions.SDLVideoStreamingRange works properly with other
init
methods.Reproduction Steps
SDLVideoStreamingRange
let landscapeDiagonal = SDLVideoStreamingRange()
landscapeDiagonal.minimumDiagonal = 5.0
streamingMediaConfig.supportedPortraitStreamingRange = SDLVideoStreamingRange.disabled()
Expected Behavior
App streams successfully
Observed Behavior
App does not stream
OS & Version Information
Test Case, Sample Code, and / or Example App
https://smartdevicelink.com/en/guides/iOS/video-streaming-for-navigation-apps/video-streaming-ios/#creating-the-video-streaming-ranges
The text was updated successfully, but these errors were encountered: