Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deprecate SDLVideoStreamingRange.init #2058

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

joeljfischer
Copy link
Contributor

Fixes #2050

Risk

This PR makes minor API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Unit tests updated, duplicate tests removed

Core Tests

Basic video streaming tests run

Core version / branch / commit hash / module tested against: Sync 3.4
HMI name / version / branch / commit hash / module tested against: Sync 3.4

Summary

This PR deprecates SDLVideoStreamingRange.init to make explicit that it's the same as .disabled.

Changelog

Bug Fixes
  • Deprecates SDLVideoStreamingRange.init to clarify that it's equivalent to .disabled.
  • Fix SDLVideoStreamingRange.initWithMinimumResolution:maximumResolution:minimumAspectRatio:maximumAspectRatio:minimumDiagonal not properly capping aspect ratios or diagonals.

Tasks Remaining:

n/a

CLA

* Update tests, remove duplicate tests
@joeljfischer joeljfischer added bug A defect in the library manager-streaming-video Relating to the manager layer - video streaming labels Oct 26, 2021
@joeljfischer joeljfischer self-assigned this Oct 26, 2021
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #2058 (cc02da9) into develop (805edd7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2058   +/-   ##
========================================
  Coverage    85.82%   85.82%           
========================================
  Files          447      447           
  Lines        23299    23299           
========================================
  Hits         19997    19997           
  Misses        3302     3302           

@joeljfischer joeljfischer merged commit bc3054b into develop Nov 1, 2021
@joeljfischer joeljfischer deleted the bugfix/issue-2050-videostreamingrange-init branch November 1, 2021 13:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug A defect in the library manager-streaming-video Relating to the manager layer - video streaming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants