Deprecate SDLVideoStreamingRange.init #2058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2050
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Unit tests updated, duplicate tests removed
Core Tests
Basic video streaming tests run
Core version / branch / commit hash / module tested against: Sync 3.4
HMI name / version / branch / commit hash / module tested against: Sync 3.4
Summary
This PR deprecates
SDLVideoStreamingRange.init
to make explicit that it's the same as.disabled
.Changelog
Bug Fixes
SDLVideoStreamingRange.init
to clarify that it's equivalent to.disabled
.SDLVideoStreamingRange.initWithMinimumResolution:maximumResolution:minimumAspectRatio:maximumAspectRatio:minimumDiagonal
not properly capping aspect ratios or diagonals.Tasks Remaining:
n/a
CLA