Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

SDLOnLockScreenStatus doesn't use constants for property keys. #497

Closed
asm09fsu opened this issue Jan 18, 2017 · 1 comment
Closed

SDLOnLockScreenStatus doesn't use constants for property keys. #497

asm09fsu opened this issue Jan 18, 2017 · 1 comment
Labels
best practice Not a defect but something that should be improved anyway
Milestone
5.0.0

Comments

@asm09fsu
Copy link
Contributor

Bug Report

Currently, SDLOnLockScreenStatus does not use constants (or macros in pre-5.0) for their properties, which is standard for RPCs and notifications.

OS & Version Information
  • SDL iOS Version: 4.5
@asm09fsu asm09fsu added best practice Not a defect but something that should be improved anyway low priority labels Jan 18, 2017
@asm09fsu asm09fsu added this to the 5.0.0 milestone Jan 18, 2017
@asm09fsu asm09fsu mentioned this issue Jan 18, 2017
Merged
@joeljfischer
Copy link
Contributor

I think this is because it's not actually in the SDL Core RPC spec?

I don't see it anywhere in here:

https://github.com/smartdevicelink/sdl_core/blob/master/src/components/interfaces/MOBILE_API.xml

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
best practice Not a defect but something that should be improved anyway
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@asm09fsu @joeljfischer