Added constants for SDLOnLockScreenStatus. #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asm09fsu
added
the
best practice
…lockscreen_constants * origin/develop: Fixed issue around not calculating an SDLPutFile's currentOffset correctly. Updated unit tests to cover all SDLPutFiles, not just the first. Added in missing implementations of dictionary categories. Moved the import from SDLRPCStruct to implementation of all classes to remove build warning of redefinition Removed nonexistent files from project Added nullability annotations. Fixed issue using incorrect name for search address. Migrated to using a category instead of adding the classes to the subclass of SDLRPCStruct. Updated missing parameters. Updated setter/getter for all rpcs and structs to use convenience methods. # Conflicts: # SmartDeviceLink/SDLOnLockScreenStatus.m
…lockscreen_constants * origin/develop: Update for v4.5.1 Added a ParameterAssert instead of throwing an exception, along with returning a handler with an error. Updated to throw an exception instead of returning an error for nil requests being sent. Adding a spec to test sending nil request. Added check for nil request in sending.
…lockscreen_constants * origin/develop: Removed unused property in unit test. Fixed renamed variable in unit tests.
…lockscreen_constants * origin/develop: Fixed issue with incorrectly parsing SDLRPCResponses.
Current coverage is 55.60% (diff: 100%)
|
joeljfischer
approved these changes
Jan 23, 2017
|
This could be on master as well since it makes no API changes. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #497
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Since we are simply replacing strings with constants, the current testing scheme should be fine.
Summary
Changed strings to utilize constants.
Changelog
Enchancements