WIP: SDL 0159 Static SDL Icon Name Enum #1034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… manager * Cleaner code
* Don’t update on display layout if unused * Don’t update on hmi non-none if not waiting for an update
… images finish uploading
…uttons_disappear_HMI_none Fix SoftButtons, Text, and Graphics disappearing on display layout change
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
…nto feature/issue_944_static_sdl_icon_name_enum
Added convenience init to SDLImage that takes a SDLStaticIconName Signed-off-by: NicoleYarroch <nicole@livio.io>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #944
This PR is not ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Test cases added to the SDLStaticIconNameSpec
Summary
Create a strongly typed enum for static SDL icon names and added a convenience initializer to the SDLImage class that takes the new enum.
Changelog
Enhancements
CLA