Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Check class type to take care of the case textField.name has "long" type #1123

Conversation

t-yoshii
Copy link

Fixes #1122

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

I tested with my devboard HU.

Summary

Add a type check in SDLDisplayCapabilities+ShowManagerExtensions#maxNumberOfMainFieldLines.

Changelog

Bug Fixes
  • Avoid crash by adding type check at SDLDisplayCapabilities+ShowManagerExtensions#maxNumberOfMainFieldLines.

CLA

@joeljfischer joeljfischer self-requested a review November 26, 2018 20:27
@joeljfischer joeljfischer added the bug A defect in the library label Nov 26, 2018
@joeljfischer
Copy link
Contributor

Hi @t-yoshii are there any production units that exhibit this issue? If the issue will be mitigated before any production head units show the issue, it would be preferable to have this fixed on SDL Core instead of creating special case fixes that are not needed.

@t-yoshii
Copy link
Author

Hi @joeljfischer ,

Thanks for your comments.
I confirmed that our customer's real HU also hit this issue. Those HUs will be released this December, so we cannot fix HU side (SDL Core or HMI).
In addition, fix for Core requires API change, so, It takes a long time for the permanent fix to be applied.

It would be greatly appreciated if you approve this PR.

@joeljfischer joeljfischer merged commit ee73c29 into smartdevicelink:master Nov 27, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug A defect in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants