Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add a check before popping the mutable data queue buffer #1435

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Add a check before popping the mutable data queue buffer #1435

merged 1 commit into from
Oct 14, 2019

Conversation

joeljfischer
Copy link
Contributor

Fixes #1433

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Unit tests were run

Summary

Added a check to the SDLMutableDataQueue buffer to prevent crashes when attempting to pop the buffer.

Changelog

Bug Fixes
  • Fixed a possible crash when popping some data off the buffer internally.

Tasks Remaining:

  • [Task 1]
  • [Task 2]

CLA

@joeljfischer joeljfischer added the bug A defect in the library label Oct 14, 2019
@joeljfischer joeljfischer self-assigned this Oct 14, 2019
@justingluck93 justingluck93 self-requested a review October 14, 2019 16:42
@joeljfischer joeljfischer merged commit 58216db into develop Oct 14, 2019
@joeljfischer joeljfischer deleted the bugfix/issue-1433-mutabledatabuffer-bounds branch October 14, 2019 17:11
@theresalech theresalech mentioned this pull request Oct 15, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@justingluck93 justingluck93 justingluck93 approved these changes

Assignees

@joeljfischer joeljfischer

Labels
bug A defect in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeljfischer @justingluck93