Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix wording in warning messages #1458

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Fix wording in warning messages #1458

merged 1 commit into from
Oct 23, 2019

Conversation

joeljfischer
Copy link
Contributor

Fixes #1450

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

No testing needed or performed

Summary

This PR fixes the wording of a few warning logs relating to minimum versions from stating "greater" to "lesser".

Changelog

Bug Fixes
  • Fixed log wording to be correct in minimum version block warning logs.

CLA

@joeljfischer joeljfischer added the bug A defect in the library label Oct 22, 2019
@joeljfischer joeljfischer self-assigned this Oct 22, 2019
@NicoleYarroch NicoleYarroch self-requested a review October 23, 2019 12:56
@NicoleYarroch NicoleYarroch added this to the 6.4.0 milestone Oct 23, 2019
@joeljfischer joeljfischer merged commit 1572861 into develop Oct 23, 2019
@joeljfischer joeljfischer deleted the bugfix/issue_1450_warning_message_fix branch October 23, 2019 13:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@NicoleYarroch NicoleYarroch NicoleYarroch approved these changes

Assignees

@joeljfischer joeljfischer

Labels
bug A defect in the library
Projects
None yet
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joeljfischer @NicoleYarroch