Fix for voice command that contains no string should be removed

[FrankElias77]

Fixes #1964

Risk

This PR makes no API changes.

Testing Plan

• I have verified that I have not introduced new warnings in this PR (or explain why below)
• I have run the unit tests with this PR
• I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Unit Test added in SDLVoiceCommandUpdateOperationSpec file to check if pendingVoiceCommands handles voice commands with no string

Core Tests

Test applied on the example app:

Modified ProxyManager to set the voiceCommandA initial state.

Case 1: The following voiceCommands defined: voiceCommandA = ["", "Test 1", " ", "Test 2", " "], voiceCommandB = ["Test 3", "Test 4"]
Case 2: The following voiceCommands defined: voiceCommandA = ["", "Test 1", " ", "Test 2", " "]
Case 3: voiceCommandA = nil
Case 4: The following voiceCommands defined: voiceCommandA = ["", " ", "\t"]

Core version / branch / commit hash / module tested against: 7.1.0
HMI name / version / branch / commit hash / module tested against: Manticore

Summary

Update pendingVoiceCommands to prevent from sending a voice command with no string

Changelog

Breaking Changes

• N/A

Enhancements

• N/A

Bug Fixes

• Update pendingVoiceCommands to prevent from sending a voice command with no string

Tasks Remaining:

N/A

CLA

• I have signed the CLA

[codecov]

Codecov Report

Merging #1965 (2464640) into develop (b88b7d1) will decrease coverage by 0.74%.
The diff coverage is 100.00%.

❗ Current head 2464640 differs from pull request most recent head f7a0e00. Consider uploading reports for the commit f7a0e00 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1965      +/-   ##
===========================================
- Coverage    85.95%   85.20%   -0.75%     
===========================================
  Files          441      441              
  Lines        22586    22603      +17     
===========================================
- Hits         19414    19260     -154     
- Misses        3172     3343     +171     

[NicoleYarroch]

Left some comments.

[NicoleYarroch]

Left some comments

[NicoleYarroch]

Left some comments

[NicoleYarroch]

Left some comments.

[NicoleYarroch]

Suggested renaming variables for clarity.

[NicoleYarroch]

I made one suggestion to relocate a comment.

Can you also add the smoke tests you performed under Core Tests in the PR description?

[NicoleYarroch]

I made some suggestions to make the tests a little more readable.