Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added missing spec files to SmartDeviceLinkTests target #1986

Conversation

FrankElias77
Copy link
Contributor

@FrankElias77 FrankElias77 commented May 10, 2021

Fixes #1985

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

NSMutableDictionary_StoreSpec tests update

Core Tests

N/A

Core version / branch / commit hash / module tested against: Branch Develop
HMI name / version / branch / commit hash / module tested against: N/A

Summary

Added missing spec files to SmartDeviceLinkTests target. Spec file update NSMutableDictionary_StoreSpec

Changelog

Breaking Changes
  • N/A
Enhancements
  • N/A
Bug Fixes
  • N/A

Tasks Remaining:

N/A

CLA

@FrankElias77 FrankElias77 added the testing Relating to unit testing or smoke testing label May 10, 2021
@FrankElias77 FrankElias77 self-assigned this May 10, 2021
@FrankElias77 FrankElias77 changed the title Added missing spec files to smartdevicelinktests target Added missing spec files to SmartDeviceLinkTests target May 10, 2021
@FrankElias77 FrankElias77 marked this pull request as ready for review May 10, 2021 21:44
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #1986 (1b2c80b) into develop (e652c00) will increase coverage by 0.87%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1986      +/-   ##
===========================================
+ Coverage    85.09%   85.96%   +0.87%     
===========================================
  Files          441      441              
  Lines        22584    22584              
===========================================
+ Hits         19217    19414     +197     
+ Misses        3367     3170     -197     

@joeljfischer joeljfischer merged commit 42b7b1f into develop May 11, 2021
@joeljfischer joeljfischer deleted the bugfix/issue-1985-add-missing-spec-files-to-smartdevicelinktests-target branch May 11, 2021 15:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
testing Relating to unit testing or smoke testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants