Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed random failures in SDLVoiceCommandManagerSpec due to operations being canceled #2002

Conversation

FrankElias77
Copy link
Contributor

Fixes #2001

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

N/A

Core Tests

N/A

Core version / branch / commit hash / module tested against: N/A
HMI name / version / branch / commit hash / module tested against: N/A

Summary

Canceled the current executing operation when a new operation is added

Changelog

Breaking Changes
  • N/A
Enhancements
  • N/A
Bug Fixes
  • Canceled the current executing operation when a new operation is added

Tasks Remaining:

N/A

CLA

@FrankElias77 FrankElias77 added the bug A defect in the library label May 26, 2021
@FrankElias77 FrankElias77 marked this pull request as ready for review May 26, 2021 14:54
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #2002 (aee01a1) into develop (b1339ea) will increase coverage by 0.54%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2002      +/-   ##
===========================================
+ Coverage    86.09%   86.63%   +0.54%     
===========================================
  Files          441      441              
  Lines        22622    23460     +838     
===========================================
+ Hits         19476    20325     +849     
+ Misses        3146     3135      -11     

@joeljfischer joeljfischer merged commit 01e22c6 into develop Jun 23, 2021
@joeljfischer joeljfischer deleted the bugfix/issue-2001-random-failures-in-sdlvoicecommandmanagerspec-due-to-operations-being-canceled branch June 23, 2021 19:35
@joeljfischer joeljfischer added the testing Relating to unit testing or smoke testing label Jun 23, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug A defect in the library testing Relating to unit testing or smoke testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants