Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Additional check added when processing control messages #2055

Conversation

FrankElias77
Copy link
Contributor

@FrankElias77 FrankElias77 commented Oct 22, 2021

Fixes #2054

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

N/A

Core Tests

N/A

Core version / branch / commit hash / module tested against: 8.0.0
HMI name / version / branch / commit hash / module tested against: generic_hmi

Summary

Additional if check added to prevent issues when serverHandshakeData

Changelog

Breaking Changes
  • N/A
Enhancements
  • N/A
Bug Fixes
  • Additional if check added to prevent issues when serverHandshakeData

Tasks Remaining:

N/A

CLA

@FrankElias77 FrankElias77 added the protocol Relating to the protocol layer label Oct 22, 2021
@FrankElias77 FrankElias77 self-assigned this Oct 22, 2021
@FrankElias77 FrankElias77 marked this pull request as ready for review October 22, 2021 14:33
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #2055 (de4c6e0) into develop (6c38240) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

@@             Coverage Diff             @@
##           develop    #2055      +/-   ##
===========================================
- Coverage    85.83%   85.80%   -0.03%     
===========================================
  Files          447      447              
  Lines        23296    23299       +3     
===========================================
- Hits         19996    19992       -4     
- Misses        3300     3307       +7     

Co-authored-by: Joel Fischer <joeljfischer@gmail.com>
@joeljfischer joeljfischer merged commit 805edd7 into develop Oct 25, 2021
@joeljfischer joeljfischer deleted the bugfix/issue-2054-additional-check-when-processing-control-messages branch October 25, 2021 12:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
protocol Relating to the protocol layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants