-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix never upload AddSubmenu RPC (menu cell w/ subcells) primary image on RPC connections v5.0 - v7.0 #2056
Merged
joeljfischer
merged 7 commits into
develop
from
bugfix/issue-2047-menu-manager-cell-image-rpc-5.0-to-7.0
Nov 19, 2021
Merged
Fix never upload AddSubmenu RPC (menu cell w/ subcells) primary image on RPC connections v5.0 - v7.0 #2056
joeljfischer
merged 7 commits into
develop
from
bugfix/issue-2047-menu-manager-cell-image-rpc-5.0-to-7.0
Nov 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ility * Fix never upload AddSubmenu RPC (menu cell w/ subcells) primary image on RPC connections v5.0 - v7.0
joeljfischer
added
bug
A defect in the library
manager-screen
Relating to the manager layer - screen managers
labels
Oct 22, 2021
Codecov Report
@@ Coverage Diff @@
## develop #2056 +/- ##
===========================================
+ Coverage 85.82% 85.84% +0.01%
===========================================
Files 447 447
Lines 23299 23366 +67
===========================================
+ Hits 19997 20059 +62
- Misses 3302 3307 +5 |
joeljfischer
changed the title
Fix never upload AddSubmenu RPC (menu cell w/ subcells) primary image on RPC connections v5.0 - v7.0
Fix never upload AddSubmenu RPC (menu cell w/ subcells) primary image on RPC connections v5.0 - v7.1
Oct 25, 2021
FrankElias77
reviewed
Nov 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just these few comments:
- Add subMenu missing image field in sdl_allImageFieldNames property in
SDLImageField+ScreenManagerExtensions.h
- If condition update to include the subMenu icon L347
As for the tests mentioned in standup, they passed!
* Fix missing text field / image field names from "all text fields" and "all image fields" * Put text field names / image field names in alpha order
* Fix menu utilities version check to be 7.0 and add command icon check
joeljfischer
changed the title
Fix never upload AddSubmenu RPC (menu cell w/ subcells) primary image on RPC connections v5.0 - v7.1
Fix never upload AddSubmenu RPC (menu cell w/ subcells) primary image on RPC connections v5.0 - v7.0
Nov 5, 2021
FrankElias77
previously approved these changes
Nov 8, 2021
FrankElias77
approved these changes
Nov 15, 2021
joeljfischer
deleted the
bugfix/issue-2047-menu-manager-cell-image-rpc-5.0-to-7.0
branch
November 19, 2021 16:46
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2047
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Unit tests added to check file upload and RPC creation on those RPC versions without the image field
Core Tests
Tested creating a menu cell w/ subcells with an image. Note, Manticore is v7.1.0 but does not support the AddSubmenu image field, so submenu images will currently not show up.
Core version / branch / commit hash / module tested against: Core v8.0.0-RC
HMI name / version / branch / commit hash / module tested against: Generic HMI v0.11.0-RC
Summary
This PR makes two changes:
Changelog
Bug Fixes
Tasks Remaining:
n/a
CLA