Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix searchable choice set callbacks are incorrect #2065

Merged

Conversation

joeljfischer
Copy link
Contributor

@joeljfischer joeljfischer commented Nov 16, 2021

Fixes #2064

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

None changed

Core Tests

  1. Present a searchable choice set
  2. Submit a keyboard search
  3. Multiple keyboard callbacks occur, but only one per keypress should be
  4. No choice cell should be selected, but one is

Core version / branch / commit hash / module tested against: Sync 3.4
HMI name / version / branch / commit hash / module tested against: Sync 3.4

Summary

This PR ensures that a cell is not selected if the input from the perform interaction is a keyboard input.

Changelog

Bug Fixes
  • Fixes choice cell callbacks when keyboard input is submitted
  • Fixes multiple keyboard input callbacks for each keypress

Tasks Remaining:

n/a

CLA

@joeljfischer joeljfischer added bug A defect in the library manager-screen Relating to the manager layer - screen managers labels Nov 16, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #2065 (7fb64b9) into master (e180db3) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2065      +/-   ##
==========================================
- Coverage   85.82%   85.80%   -0.03%     
==========================================
  Files         447      447              
  Lines       23299    23300       +1     
==========================================
- Hits        19997    19993       -4     
- Misses       3302     3307       +5     

@joeljfischer joeljfischer changed the title Fix calling choice set delegate when keyboard input occurs Fix searchable choice set callbacks are incorrect Nov 17, 2021
@joeljfischer joeljfischer changed the base branch from master to hotfix/7.3.1 December 1, 2021 15:23
@joeljfischer joeljfischer merged commit 9a670c3 into hotfix/7.3.1 Dec 1, 2021
@joeljfischer joeljfischer deleted the bugfix/issue-2064-incorrect-keyboard-response branch December 1, 2021 15:24
@joeljfischer joeljfischer self-assigned this Dec 1, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug A defect in the library manager-screen Relating to the manager layer - screen managers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix userDidSubmitInput getting called multiple times after a search request is submitted
1 participant