Fix custom framerate not taken into account when presentation data is unavailable #750
+17
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoleYarroch
approved these changes
Sep 22, 2017
joeljfischer
deleted the
bugfix/issue_717_custom_framerate_encoding_without_custom_timestamp
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #717
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
[Describe how you plan to unit test the changes in this PR]
Summary
This PR updates current hardcoded values of "30" fps as the default to take into account custom expected framerates when applied.
Changelog
Bug Fixes
CLA