Fix SDLAddCommand initializer can't take a nil image #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow handler to be nil
joeljfischer
changed the title
NicoleYarroch
approved these changes
Feb 7, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #846
This PR is ready for review.
Risk
This PR makes minor API changes. Note that although this technically changes an API (normally a major version change), because it is merely opening up the API for a broader range of inputs, it is a minor version change and will not affect any current integrators.
Testing Plan
Unit tests will be added
Summary
Allow AddCommand initializer to create a command with a parent but no icon.
Changelog
Enhancements
SDLAddCommand initWithId:vrCommands:menuName:parentId:position:iconValue:iconType:iconTypehandler:to take a nullableiconValueandiconTypeinstead of nonnull. This will not create an Image to be sent.CLA