Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixed change registration not sent #903

Merged
merged 2 commits into from
Mar 20, 2018
Merged

Fixed change registration not sent #903

merged 2 commits into from
Mar 20, 2018

Conversation

NicoleYarroch
Copy link
Contributor

Fixes #902

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Smoke tests

Summary

  • In the SDLLifecycleManager's didEnterStateUpdatingConfiguration: method, the the change registration request is now sent with via sendConnectionManagerRequest:handler instead of sendRequest:. This bypasses the current state machine check.

CLA

@NicoleYarroch NicoleYarroch self-assigned this Mar 19, 2018
@NicoleYarroch NicoleYarroch added the bug A defect in the library label Mar 19, 2018
@NicoleYarroch NicoleYarroch added this to the 5.2.0 milestone Mar 19, 2018
@NicoleYarroch NicoleYarroch changed the title Bugfix/issue 902 change registration not sent Fixed change registration not sent Mar 19, 2018
@joeljfischer joeljfischer merged commit 830f0c8 into develop Mar 20, 2018
@joeljfischer joeljfischer deleted the bugfix/issue_902_change_registration_not_sent branch March 20, 2018 12:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@joeljfischer joeljfischer joeljfischer approved these changes

Assignees

@NicoleYarroch NicoleYarroch

Labels
bug A defect in the library
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@NicoleYarroch @joeljfischer