Added support for setting a custom CarWindow screen resolution #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Preferred resolution is now set, even if video capabilities is not supported by Core - Preferred resolution is now set when the `videoAckPayload` does not return a width or height - Exposed the `SDLStreamingMediaManagerDataSource` files
NicoleYarroch
changed the title
NicoleYarroch
changed the title
joeljfischer
suggested changes
Apr 6, 2018
| } // else we are using the screen size we got from the RAIR earlier | ||
| } else { | ||
| // If a preferred resolution was set, use the first option to set the screen size | ||
| if (self.preferredResolutions.count > 0) { |
There was a problem hiding this comment.
can we combine the else above and this if?
| } else { | ||
| // If a preferred resolution was set, use the first option to set the screen size | ||
| if (self.preferredResolutions.count > 0) { | ||
| SDLImageResolution *preferredResolution = self.preferredResolutions[0]; |
There was a problem hiding this comment.
self.preferredResolutions.firstObject is a tiny change, but I personally like to use it.
joeljfischer
approved these changes
Apr 9, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #908
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Test cases added to the
SDLStreamingMediaLifecycleManagerSpec.Summary
GetSystemCapabilityis not supported by Core.videoAckPayloaddoes not return values for width and height.SDLStreamingMediaManagerDataSourcefile is now public.Changelog
Breaking Changes
None
Tasks Remaining:
CLA