Null handling in divide #489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves issue smarthomej#488 Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
J-N-K
reviewed
May 30, 2023
| logger.warn("Input value '{}' could not be converted to a valid number", valueString); | ||
| throw new TransformationException("Math Transformation can only be used with numeric inputs"); | ||
|
|
||
| if("NULL".equals(valueString) || "NULL".equals(sourceString)) { |
There was a problem hiding this comment.
Wouldn't it make sense to check UNDEF, too?
There was a problem hiding this comment.
Wouldn't it make sense to check
UNDEF, too?
You're correct, I thought of it but I only faced the error with NULL, never UNDEF, so thought : if not broken, don't fix it :)
|
I added another version to get it into 3.2.17 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposal to address what I think is an issue #488