This repository was archived by the owner on Aug 14, 2018. It is now read-only.
Double-encoding of certain characters in path fragments for non-S3 URLs #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first-crack at resolving #28, which is particularly troubling when trying to do multi-index or multi-type searching on AWS Elasticsearch Service.
Please Note
I'm not as familiar with the AWS V4 signing process as I'd like to be. For that reason, this will probably take some scrupulous review by the authors/maintainers. I'm happy to make any alterations, though, so please feel free to ask!
This was altered for our application of go-aws-auth for the Elasticsearch service, and we do not use it for any other service, so if anyone is using other services then testing this signing with your services would be much appreciated.