Throw deprecation notice about unregistered functions without changing the compilation flow #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the compilation flow. Fixes #964
wxiaoguang
reviewed
Feb 18, 2025
|
|
||
| if ( | ||
| !$this->smarty->loadPlugin('smarty_modifiercompiler_' . $name) | ||
| && !isset($this->smarty->registered_plugins[Smarty::PLUGIN_MODIFIER][$name]) |
There was a problem hiding this comment.
Why it only checks PLUGIN_MODIFIER but not PLUGIN_FUNCTION?
Do I need to register sprintf (for example) as modifier and function at the same time?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #964