Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixes #24 | Make the header sticky #25

Merged
merged 6 commits into from
Dec 2, 2017
Merged

Fixes #24 | Make the header sticky #25

merged 6 commits into from
Dec 2, 2017

Conversation

kerrtravers
Copy link
Contributor

  • Make the header sticky
  • Make sure it doesn't clash with anything, especially the top header
  • Make sure it looks good overall

@kerrtravers kerrtravers self-assigned this Dec 2, 2017
@kerrtravers kerrtravers added this to the Christmas Design milestone Dec 2, 2017
Kenny2github
Kenny2github requested changes Dec 2, 2017
View reviewed changes
Copy link
Member

@Kenny2github Kenny2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem:
image
The header (yours above) is squashed compared to the original, below:
image

@kerrtravers
Copy link
Contributor Author

Okay, I'll fix that 👍

(I didn't know you wanted to have as much padding)

@Kenny2github Kenny2github merged commit 1189b86 into smelt-modding:master Dec 2, 2017
@kerrtravers
Copy link
Contributor Author

👍

@smelt-modding smelt-modding deleted a comment from kerrtravers Dec 2, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Kenny2github Kenny2github Kenny2github approved these changes

Assignees

@kerrtravers kerrtravers

Labels
design feature prnr website
Milestone
Christmas Design
Development

Successfully merging this pull request may close these issues.
2 participants
@kerrtravers @Kenny2github