Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change to manipulate the PATH #27

Merged
merged 2 commits into from
Jan 21, 2018
Merged

Change to manipulate the PATH #27

merged 2 commits into from
Jan 21, 2018

Conversation

Kenny2github
Copy link
Member

@Kenny2github Kenny2github commented Jan 21, 2018 •
edited
Loading

Changes

Previously, new commands would be installed by copying them to %USERPROFILE% and manually doskeying them. Now there is only one file: %USERPROFILE%\init.cmd that simply adds the extension directory to the PATH on startup and doskeys sbpm.bat instead - much more elegant.
Besides this, sbpm.bat previously used a switch for the subcommand - now it simply calls the corresponding batch file.
Finally, uninstalling no longer has to remove the userprofile batch files.

Test coverage

Tested locally on Windows 8; will do QA on Win10 post-merge.

Note

Previously I said this was a breaking change - it isn't, when updating it fully uninstalls everything before downloading the new version :D

@Kenny2github
Change to manipulate the PATH
cf2d59b
@Kenny2github
Tweaks
c5227f8 
Removed last vestiges of old method
Removed trailing spaces -.-
Allowed the /upgrade argument again
@Kenny2github Kenny2github self-assigned this Jan 21, 2018
@Kenny2github
Copy link
Member Author

Technically it's not performance, so I've removed that label.

kerrtravers
kerrtravers approved these changes Jan 21, 2018
View reviewed changes
Copy link
Contributor

@kerrtravers kerrtravers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kerrtravers kerrtravers added prgtm and removed prnr labels Jan 21, 2018
@Kenny2github Kenny2github merged commit e87e6f9 into master Jan 21, 2018
@Kenny2github Kenny2github deleted the manipulate-path branch January 21, 2018 13:55
@Kenny2github
Copy link
Member Author

QA on Win10 after merge: OK!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kerrtravers kerrtravers kerrtravers approved these changes

@elizso elizso Awaiting requested review from elizso

Assignees

@Kenny2github Kenny2github

Labels
enhancement prgtm QA-OK
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kenny2github @kerrtravers