Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

2018 Full Site Update #28

Merged
merged 7 commits into from
Jan 25, 2018
Merged

2018 Full Site Update #28

merged 7 commits into from
Jan 25, 2018

Conversation

kerrtravers
Copy link
Contributor

Changes

  • All CSS is now imported from the bootstrap CDN
  • Everything on the site has been updated
  • A new button to report an issue in the known issues section
  • A "view the code" section
  • A copyright and host notice at the bottom
  • A full redesign of the status page
  • A full redesign of the 404 page
  • Easier to download as the download link is a button instead of a normal anchor tag.
  • Cleared out old images from the repo
  • Put the images into a folder

Preview It

https://vutondesign.com/smelt-modding.github.io

@kerrtravers kerrtravers self-assigned this Jan 21, 2018
Kenny2github
Kenny2github requested changes Jan 21, 2018
View reviewed changes
Copy link
Member

@Kenny2github Kenny2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really cool! However, I’d like it if you could make each subsection actually a subsection - i.e. instead of “to install: do this” make it a subsection with title “to install” and content “do this” - does that make sense?

Kenny2github
Kenny2github reviewed Jan 21, 2018
View reviewed changes
Copy link
Member

@Kenny2github Kenny2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few extra comments as well.

404.html Outdated
<br/>
<div class="jumbotron">
<h2> 404 </h2>
<h3> You seem a bit lost, there doesn't seem to be anything here... </h3>
Copy link
Member

@Kenny2github Kenny2github Jan 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this string back? I liked the MLT quote.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay 👍

index.html
<li>Double-click <code>reinstall.bat</code></li>
<li>You're done! Logs will be available at <code>logs\uninstall.log</code> and <code>logs\install.log</code>.</li>
</ol>
<!-- Smelt Navbar -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML comments, nice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, It's quite a long HTML file with a lot of <div>'s, So it's better to know exactly where everything starts and ends.

@kerrtravers
Copy link
Contributor Author

Just pushed the requested changes. 👍

Kenny2github
Kenny2github reviewed Jan 22, 2018
View reviewed changes
Copy link
Member

@Kenny2github Kenny2github left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this once I can actually see the preview ;)
LGTM though!

Kenny2github
Kenny2github requested changes Jan 23, 2018
View reviewed changes
Copy link
Member

@Kenny2github Kenny2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nitpick about style and a little inaccuracy.

index.html
<h3>To install commands pre-downloaded from other sources:</h3>
<ol>
<li>Move the downloaded commands into the <code>extensions</code> folder.</li>
<li>Double-click <code>install.bat</code></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the preview, <code> tags do seem to be monospaced, but blue highlight isn't really good - I'd prefer default font color and some sort of background color - preferably with a little padding.

index.html Outdated
<p class="lead">Delete the previous versions from the <code>extension</code> folder and Move the new versions into the <code>extension</code> folder. Now just double-click <code>reinstall.bat</code>, and you're done! Logs will be available at <code>logs\uninstall.log</code> and <code>logs\install.log</code>.</p>
<br/>
<h2>To upgrade commands available here:</h2>
<p class="lead">Open Command Prompt (Win+R, type cmd and hit Enter/Win+X, C) and type sbpm install <code>_package_/upgrade</code> (replace <code>_package_</code> with the name of the desired package). You're done! A log will be available at <code>logs\install.log</code>.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace sbpm install <code>_package_/upgrade</code> with <code>sbpm install _package_ /upgrade</code>.

  1. sbpm install is part of the command...
  2. There is a space between _package_ and /upgrade - so _package_ /upgrade instead of _package_/upgrade.

Also, you might want to make a note of /U being a shorter alternative to /upgrade - both do the same thing, but if you know the former, it's quicker.

@Kenny2github Kenny2github removed the request for review from elizso January 23, 2018 08:38
@Kenny2github Kenny2github added prnw and removed prnr labels Jan 23, 2018
Kenny2github
Kenny2github reviewed Jan 23, 2018
View reviewed changes
Copy link
Member

@Kenny2github Kenny2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, by the way, could you also change it so that anywhere it said "double-click foo.bat" it now says "run sbpm foo"? thanks

@kerrtravers kerrtravers added prnr and removed prnw labels Jan 23, 2018
Kenny2github
Kenny2github requested changes Jan 23, 2018
View reviewed changes
Copy link
Member

@Kenny2github Kenny2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a last change, and this should be good to go!

index.html
<title>Smelt: Batch Package Manager</title>
<style>
code {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start - change this CSS section to:

code {
    color: black;
    background-color: <something>;
    padding: <something>;
}

Replace <something> with something that looks nice :)

Kenny2github
Kenny2github approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@Kenny2github Kenny2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thanks for this :)

@Kenny2github Kenny2github merged commit a30ebe8 into smelt-modding:master Jan 25, 2018
@kerrtravers kerrtravers added prgtm and removed prnr labels Mar 10, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Kenny2github Kenny2github Kenny2github approved these changes

Assignees

@kerrtravers kerrtravers

Labels
design prgtm website
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerrtravers @Kenny2github