Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Full Re-Design #4

Merged
merged 24 commits into from
Oct 9, 2017
Merged

Full Re-Design #4

merged 24 commits into from
Oct 9, 2017

Conversation

kerrtravers
Copy link
Contributor

@kerrtravers kerrtravers commented Oct 8, 2017

Why are you making this request?

The site looked a bit old and plain, So I've taken the css from my old site and customized it to fit the style of Smelt.

What issue does this reference/resolve?

#3

Preview

capture

Tested on:

http://vutondesign.com/smelt-modding.github.io/

Copy link
Member

@Kenny2github Kenny2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Though your design is on point (and judging from the screenshots, it’s looking a lot better), your code style needs a bit of work. Would you mind making consistent indentation? Thanks.

background:black;
color:white;
font-family:Courier New, monospace;
* {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this

index.html Outdated
<h3 id="uninstall-part">To uninstall a command installed with SBPM:</h3>
<ol>
<li>Open Command Prompt (Win+R, type <code>cmd</code> and hit Enter/Win+X, C)</li>
<li>Type <code>sbpm uninstall &lt;package></code> (replace <code>&lt;package></code> with the name of the desired package.)</li>
<li>You're done! A log will be available at <code>logs\uninstall.log</code>.</li>
</ol>
</div>
<div class="boxes">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some weird indentation - would you mind making everything consistent? I.e.

    </ol>
</div>
<div class="boxes">

index.html Outdated
<h1>Smelt: Batch Package Manager</h1>
</center>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, too - your indentation generally needs work.

@kerrtravers
Copy link
Contributor Author

@Kenny2github I'll work on all of this 👍

@kerrtravers
Copy link
Contributor Author

Done, How's that?

Copy link
Member

@Kenny2github Kenny2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better! I’m not going to be too nit picky about indentation (I can solve it myself) so I’ll merge this now.

@Kenny2github Kenny2github merged commit 427723f into smelt-modding:master Oct 9, 2017
@kerrtravers kerrtravers mentioned this pull request Oct 9, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

2 participants