chore: re-enable ignored Kotlin/Native tests #1379
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
added
the
no-changelog
lauzadis
approved these changes
Aug 13, 2025
| @@ -69,7 +68,6 @@ private val TESTS = listOf( | |||
| * Tests for [SigV4aSignatureCalculator]. Currently only tests forming the string-to-sign. | |||
| */ | |||
| class SigV4aSignatureCalculatorTest { | |||
| @IgnoreNative // FIXME test resources are not loadable on iOS: https://youtrack.jetbrains.com/issue/KT-49981/ | |||
There was a problem hiding this comment.
Did you have to do anything to fix this?
There was a problem hiding this comment.
I worked on this test before and I didn't need to do anything to fix it. I don't know if Ian's work changed something related though.
There was a problem hiding this comment.
Yes, this seems to Just Work™ now.
ianbotsf
added
the
acknowledge-api-break
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
Re-enables all
@IgnoreNativetests after the fixes in awslabs/aws-crt-kotlin#175 and awslabs/aws-crt-kotlin#176By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.