feat: jreleaser check workflow #1398
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
added
the
no-changelog
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+9
to
+12
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: JReleaser check | ||
| uses: awslabs/aws-kotlin-repo-tools/.github/actions/jreleaser@jreleaser-check # TODO: Change branch to main after testing/merge |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
To fix the problem, we should declare an explicit permissions block for the jreleaser-check job in .github/workflows/jreleaser.yml. Since the workflow is for a check action and does not appear (from the provided snippet) to require write access to repository contents, we should set the permissions to the minimal necessary, which is typically contents: read. Adding this block directly underneath the job name (jreleaser-check:) ensures the token cannot be abused for escalation or unintended write actions.
Suggested changeset
1
.github/workflows/jreleaser.yml
| @@ -6,6 +6,8 @@ | ||
|
|
||
| jobs: | ||
| jreleaser-check: | ||
| permissions: | ||
| contents: read | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: JReleaser check |
Copilot is powered by AI and may make mistakes. Always verify output.
This comment has been minimized.
This comment has been minimized.
1 similar comment
Affected ArtifactsChanged in size
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
See: awslabs/aws-kotlin-repo-tools#119
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.