Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Default Provider Chain #650

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Add Default Provider Chain #650

merged 4 commits into from
Aug 12, 2021

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Aug 12, 2021

Motivation and Context

Credential Providers define a default chain of providers that are used if no other credential providers are specified.

Description

  • Adds an initial implementation of the default credentials provider chain. First, it will use environment variables. Next it will use shared config / profiles.
  • Make small refactorings to smithy-client to expose https connectors

Testing

  • Manual testing via examples
  • Unit testing of edge cases

Checklist

  • I have updated the CHANGELOG

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested a review from jdisanti August 12, 2021 18:50
This commit adds an initial implementation of the default credentials provder chain. First, it will use environment variables. Next it will use shared config / profiles.
Copy link
Collaborator

@jdisanti jdisanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple doc comment fixes. Otherwise, looks good!

rcoh and others added 2 commits August 12, 2021 16:56
@rcoh rcoh enabled auto-merge (squash) August 12, 2021 20:56
@rcoh rcoh merged commit 4b488c2 into main Aug 12, 2021
@rcoh rcoh deleted the default-chain branch August 12, 2021 21:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants