Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add a minimal implementation of shared config #673

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Add a minimal implementation of shared config #673

merged 2 commits into from
Aug 27, 2021

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Aug 27, 2021 •
edited
Loading

Motivation and Context

#655

Description

Adds:

  • a minimal shared config that only sets region.
  • adds from/new functions to service config structs

Testing

  • in memory test to ensure region is passed through properly

Checklist

  • I have updated the CHANGELOG

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested a review from jdisanti August 27, 2021 19:27
@rcoh rcoh merged commit bab8e23 into main Aug 27, 2021
@rcoh rcoh deleted the min-shared-config branch August 27, 2021 20:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jdisanti jdisanti jdisanti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcoh @jdisanti